Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed temporary override logic. #1882

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Changed temporary override logic. #1882

merged 1 commit into from
Oct 4, 2023

Conversation

cmaddox5
Copy link
Contributor

@cmaddox5 cmaddox5 commented Oct 3, 2023

Asana task: ad-hoc

Tweaked the logic so we do not show an alert for the Haymarket closure on Tufts and Back Bay Pre-Fare screens.

  • Tests added?

@cmaddox5 cmaddox5 requested review from a team and PaulJKim and removed request for a team October 3, 2023 12:14
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Coverage of commit 68ff06b

Summary coverage rate:
  lines......: 40.4% (2296 of 5684 lines)
  functions..: 41.8% (1051 of 2512 functions)
  branches...: no data found

Files changed coverage rate:
                                                                           |Lines       |Functions  |Branches    
  Filename                                                                 |Rate     Num|Rate    Num|Rate     Num
  ===============================================================================================================
  lib/screens/v2/widget_instance/reconstructed_alert.ex                    |90.2%    164|95.7%    23|    -      0

Download coverage report

@cmaddox5 cmaddox5 merged commit 7f0bd27 into master Oct 4, 2023
4 checks passed
@cmaddox5 cmaddox5 deleted the cm/ol-tufts-bb-alert-suppression branch October 4, 2023 18:14
cmaddox5 added a commit that referenced this pull request Oct 4, 2023
@cmaddox5
Revert "Changed temporary override logic. (#1882)"
da15cf6 
This reverts commit 7f0bd27.
cmaddox5 added a commit that referenced this pull request Oct 4, 2023
@cmaddox5
Revert "Changed temporary override logic." (#1884)
37bdf0e 
* Revert "Changed temporary override logic. (#1882)"

This reverts commit 7f0bd27.

* Update reconstructed_alert.ex

Removed old alert IDs too.

* Update reconstructed_alert.ex

Changed function name to be less confusing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulJKim PaulJKim PaulJKim approved these changes

Assignees

@PaulJKim PaulJKim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmaddox5 @PaulJKim